[ck] [PATCH 16/17] tpm: fix wrong return value in tpm_pcr_extend

From: Tianjia Zhang &lt;tianjia.zhang(a)linux.alibaba.com&gt; commit 29cb79795e324a8b65e7891d76f8f6ca911ba440 upstream. For the algorithm that does not match the bank, a positive value EINVAL is returned here. I think this is a typo error. It is necessary to return an error value. Cc: stable(a)vger.kernel.org # 5.4.x Fixes: 9f75c8224631 ("KEYS: trusted: correctly initialize digests and fix locking issue") Signed-off-by: Tianjia Zhang &lt;tianjia.zhang(a)linux.alibaba.com&gt; Reviewed-by: Roberto Sassu &lt;roberto.sassu(a)huawei.com&gt; Reviewed-by: Jerry Snitselaar &lt;jsnitsel(a)redhat.com&gt; Reviewed-by: Jarkko Sakkinen &lt;jarkko.sakkinen(a)linux.intel.com&gt; Signed-off-by: Jarkko Sakkinen &lt;jarkko.sakkinen(a)linux.intel.com&gt; Signed-off-by: mayuanchen &lt;mayuanchen(a)hygon.cn&gt; Change-Id: I9d5a572d37bd6162bcd4c2cb792b8d80c208b8f2 --- drivers/char/tpm/tpm-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index 74362e287d59..659b887bd454 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -1059,7 +1059,7 @@ int tpm_pcr_extend(struct tpm_chip *chip, u32 pcr_idx, for (i = 0; i < chip->nr_allocated_banks; i++) { if (digests[i].alg_id != chip->allocated_banks[i].alg_id) { - rc = EINVAL; + rc = -EINVAL; goto out; } } -- 2.17.1